Commit
6 years ago
master -> Next (#520) * Fix dep vs peer dep (#408) * Add CODEOWNERS file for spectrum-css (#418) * Close ToastContainer `help` function fails because "help" is not a supported Toast variant #253 (#409) * remove help * RSP-716 [Accessibility][Documentation] StatusLight (#420) Update StatusLight Storybook examples and documentation. * Fix #421 Don't expose css className for `u-react-spectrum-screenReaderOnly` as API (#423) * Fix #421 Don't expose css className for `u-react-spectrum-screenReaderOnly` as API We shouldn't expose our css classes as API. Instead we should provide components that apply them. https://github.com/adobe/react-spectrum/pull/420/files#r298298301 * Fix #421 VisuallyHidden should be a public component rather than a utility * Use dive() rather than shallow() in enzyme unit tests * Closable Alert component #329 (#330) * RSP-702 [Accessibility][Documentation] OverlayTrigger (#352) * v3 update internal stateRef for controlled components (#422) * Updating stateRef in useControlledState for controlled components If a component is controlled and it's controlled value prop changes, we need to update the internal stateRef so future onChange events properly trigger only if a different internal state value is provided * Merging if statements in useControlledState * Adds Accessibility Info for Wait and Well (#431) * [Accessibility] [Documentation] Well Component * [Accessibility][Documentation] Wait Component * Modified in response to review comments * Add role to doc for Well * Fix #400, RSP-709, RSP-710, RSP-711, RSP-712 [Accessibility][Documentation] Search, SearchWithin, Select, SelectList (#401) Fixes: - #400 [Accessibility] SearchWithin: improve labelling of child Search and Select controls - RSP-709 [Accessibility][Documentation] Search - RSP-710 [Accessibility][Documentation] SearchWithin - RSP-711 [Accessibility][Documentation] Select - RSP-712 [Accessibility][Documentation] SelectList What changed: 1. Search input should have `type="search"`. 2. Refactor `aria-label` and `aria-labelledby` props in SearchWithin. 3. Added `autoFocus` prop to SearchWithin, so that search input will support `autoFocus`. 4. Refactor `aria-label` prop for Select. 5. Fix SelectList story for `renderItem` so that it behaves as described. 6. Update tests for Search, SearchWithin, Select and SelectList, improving coverage 7. Update documentation for Search, SearchWithin, Select and SelectList 8. Correct Heading `variant` and `aria-level` props in documentation. * #451 DropdownButton menuClassName prop has invalid PropType (#452) * Github Template updates (#456) * Icons v3 (#410) * (#302) v3 TextField, TextArea, SearchField (#413) * (#194) - v3 SplitView (#201) * #168: Add ModalTrigger warning if less than two children (#446) * Add ModalTrigger warning if less than two children * Print names of children in warning * update copy * Ignore typescript errors when building icons (#462) Unfortunately, typescript includes all files in the repo when compiling icons, not just icon related ones. If you have any typescript errors in your current branch, the icons would fail to build and you could not start storybook. However, typescript still emitted the .d.ts files as expected. This just ignores ts errors when building icons. * v3 Adding optional prop exclusion array to filterDOMProps (#445) * Adding ability to exclude props from user provided list to filterDOMProps * Renaming excludeArray to exclude * Changing exclude array to exclude obj Exclude obj merges with base DOMprops and overrides any that overlap * removing extraneous paren * Renaming input argument for clarity sake * RSP-714 [Accessibility][Documentation] SplitButton (#417) * Add SplitButton accessibility documentation. * Update unit tests for complete coverage. * Use stopPropagation on Alt+ArrowDown so that Storybook does not jump to next component. * [#435] Fix for DropdownButton and undefined prop when using HMR (#436) * Fix for DropdownButton and undefined props when using HMR * Add in fallback to look for the last child * `renderTag` attribute for TagField allows for custom tag rendering (#442) * Added renderTag prop to TagField Allows avatars in TagField as well as other options for tag rendering * Wrote untested docs * Added test * Typo fix * Changed null to undefined * Increased code clarity with `coercedValue` * Fixed onRemove in TagField * onChange emits strings instead of objects * #449 Replace lodash/isEmpty with javascript function (#455) * Replace lodash/isEmpty with javascript function * Add isEmpty to utils and import * Remove Tool Button (#472) * Remove Tool Button * typo * Remove redundant role="spinbutton" from NumberInput (#478) * Remove redundant role="spinbutton" from NumberInput The `NumberInput` component's `Textfield` had the attribute `role="spinbutton"`. This was redundant, since it also has the attribute `type="number"`, which natively sets `role="spinbutton"`. This came up as an accessibility failure in AAM's accessibility audit, conducted by Level Access. AAM bug: https://jira.corp.adobe.com/browse/AAM-48931 * Add NumberInput test: verify `type="number"` exists on Textfield * Fixing Icon so that user can pass in size (#480) * Update storybook and corejs (#468) * performing maintenance to keep us up to date * Added custom title to storybook and a version number too * Added custom theme and title/version to v2 as well * Render items in tag field (#470) * Added renderItems to TagField * Test written * edit info for renderItem story * Support for className prop child Buttons in ButtonGroup (#486) * Support for className prop child Buttons in ButtonGroup * v3 Popovers, Modals, and Interactions (#419) * Starting work on overlays * wip: press interaction * Use press interaction in buttons * Implement focus containment, focus restoring, and auto focus in FocusScope * Add focus ring to buttons * Move useMediaQuery into utils * Implement overlays * Restore focus to active focus scope when tabbing from outside browser * Focus overlay on mount if no child is already focused * Move modal styles into a separate component folder * Add aria-hidden to providers outside active modal * Clean up * Add focus ring to all buttons * Merge ModalTrigger and PopoverTrigger into DialogTrigger * TypeScript is dumb * Linter * useButton/usePress cleanup * Fix button tests * Positioning props * Remove storybook addon info * Add tests for usePress hook * Tests for useInteractOutside * port calculatePosition tests from v2 * useOverlay tests * useOverlayTrigger tests * Tests for useOverlayPosition * useModal tests * review comments * update dependencies * Always preventDefault on Tab key in FocusScope * Popover tests * Overlay tests * Tests for Modal * Tray tests * DialogTrigger tests * Fix dependencies * Fix placement bug and add more stories * Move some dialog specific behavior into useDialog hook * Test cleanup * linting * Add tests for FocusScope * disable no-autofocus lint rule * Move dialog specific modal stuff into dialog package * RSP-1197 [Accessibility][Documentation] GridView (#475) * RSP-722 [Accessibility][Documentation] TableView (#476) * RSP-1008 [Accessibility][Documentation] ColumnView (#479) Improve Accessibility section of ColumnView documentation with link to WAI-ARIA specification and example of how to label the control. * Bucketing overlays basis the role (#485) * Add PressResponder and Pressable components (#490) * Add PressResponder and Pressable components * Replace all :active with .is-active * lint * review comments * Support controlled DialogTrigger, and add stories for standalone Modal (#493) * Add support for controlled DialogTrigger * Add stories with examples of standalone modal * lint * Update DialogTrigger.tsx * TagField duplicate behavior for objects as values (#471) * Small issues with new way of checking to see if value is already in the taglist fix some lint stuff * add another test * fix things up to be more readable and add another test * improving pr based on second extra pr i made because i forgot about this one.... * Updating SelectList renderItem story and description (#507) * selectList renderItem story and updating description * Removing ref declaration from selectList story * Fix #510: User is able to scroll one step above and below the NumberInput range limit in Chrome (#516) Users should not be able to scroll above or below the specified range for NumberInput components. Users in Chrome are able to mouse wheel scroll one step above and below the specified range of a NumberInput component. See http://localhost:9002/?path=/story/numberinput--min-5-max-10-step-0-5 | Software | Version(s) | | ---------------- | ---------- | | react-spectrum | 2.22.0 | Browser | Chrome | Operating System | MacOS https://jira.corp.adobe.com/browse/RSP-1214 This relates to treating mouse wheel listeners as passive: https://www.chromestatus.com/feature/6662647093133312 In Chrome, we can no longer call preventDefault on a wheel event unless it explicitly added with {passive: false} option. Without preventDefault, two event handlers that increment/decrement the value of the number input are being called, handleInputScrollWheel and handleInputChange. The solution is to add the wheel event listener with passive: false option in componentDidMount rather than using onWheel prop on TextField. * chore(release): publish
Author
Committer
Parents
Loading