react-spectrum
0f099f77 - RSP-1001, RSP-1003, RSP-1004 [Accessibility] CycleButton updates (#591)

Commit
7 years ago
RSP-1001, RSP-1003, RSP-1004 [Accessibility] CycleButton updates (#591) RSP-1001 [Accessibility] CycleButton: label applied to SVG element with aria-hidden CycleButton provides a mechanism to add a label for accessibility, however, that label is applied to an Icon that has aria-hidden by default. Solution is to use alt prop, rather than aria-hidden: true and aria-label prop when cloning the icon element. RSP-1003 [Accessibility][Documentation] CycleButton: add accessibility documentation Add accessibility section to CycleButton documentation. RSP-1004 [Accessibility] CycleButton: Improve screen reader announcement Simply changing the aria-label on the current action is insufficient to prompt screen reader to announce the new label. Add aria-live so that the new label value is announced onChange. RSP-1001, RSP-1003, RSP-1004 [Accessibility] CycleButton updates per code review RSP-1001, RSP-1003, RSP-1004 [Accessibility] CycleButton account for controlled prop
Author
Michael Jordan
Committer
Parents
Loading