react-spectrum
1725d702 - Fix combobox issue handling tab/enter custom value is allowed (#2670)

Commit
2 years ago
Fix combobox issue handling tab/enter custom value is allowed (#2670) * Fix combobox issue handling tab/enter custom value is allowed * Share logic so that tab/enter on combobx share same behaviour as when isFocused is false which is working as expected * Unit tests for retaining selected key when tab/enter * fix commit logic close shouldnt always commit the focused value (e.g when clicking to blur) so changing it back to commitValue. We should revist the commit and close logic to clean it up and clarify when to commit and when not to. --------- Co-authored-by: Biruk Desta <desta@adobe.com> Co-authored-by: Daniel Lu <dlu@livefyre.com> Co-authored-by: Kyle Taborski <ktabors@yahoo.com> Co-authored-by: Daniel Lu <dl1644@gmail.com> Co-authored-by: Reid Barber <reid@reidbarber.com>
Author
Parents
Loading