Commit
1 year ago
Breadcrumbs (#148) * initial Breadcrumbs work * improve link styles * simplify styles * add flex to macro * fix multiline * more style improvements * allow more link props * pass down link props * remove s2 link context and styles added * remove underline for disabled link * review follow-up * use marginStart: text-to-visual for chevron * remove design link * remove shorthand flex from theme * remove nav wrapper * update styles * spread props onto RAC breadcrumbs * add onAction story * add styles to Heading * ad Heading story to Breadcrumbs * fixing breadcrumb vertical padding when multiline only had to change the height, the gap between the top and current breadcrumb is already provided by the row gap of 4 which equals the breadcrumbs-start-edge-to-truncated-menu value in the spec. This value is also moreaccurate than the 9px they have for top-text-to-to-bottom-text since it starts at the bottom of the breadcrumb box * fix active style, chevron centering, and tentative styles for multiline see comments for uncertainties with margins and multiline in design * update default, wrapper padding, and isMultiLine sizing as per design feedback * review comments * fix Safari focus ring cut off * get rid of default heading styling for now --------- Co-authored-by: Reid Barber <reid@reidbarber.com> Co-authored-by: danilu <danilu@adobe.com>
Author
Reid Barber
Committer
GitHub Enterprise
Parents
Loading