DRILL-7941 Update JUnit from 4.13.2 to 5.7.2 (#2244)
* DRILL-7941 Update JUnit from 4.13.2 to 5.7.2
* DRILL-7941 Add dependency management for JUnit 4.x
This way we can control the version used by junit-vintage-engine and most importantly its scope (test).
Now the dependency:tree looks like:
[INFO] +- org.junit.vintage:junit-vintage-engine:jar:5.7.2:test
[INFO] | +- org.apiguardian:apiguardian-api:jar:1.1.0:test
[INFO] | +- org.junit.platform:junit-platform-engine:jar:1.7.2:test
[INFO] | | +- org.opentest4j:opentest4j:jar:1.2.0:test
[INFO] | | \- org.junit.platform:junit-platform-commons:jar:1.7.2:test
[INFO] | \- junit:junit:jar:4.13.2:test
Before this change the scope of junit:junit was 'compile' and its version - 4.13
The compile scope added to the total size of java-exec-all.jar and maven-enforcer rule failed
* DRILL-7941 Add junit:junit with 'provided' scope to drill-common for RepeatTestRule
Remove an obsolete comment from drill-logical/pom.xml
* DRILL-7941 Migrate few unit tests from JUnit 4.x APIs to 5.x APIs
* DRILL-7941 Move RepeatTestRule to drill-common/src/test
This way there is no need to have dependency to junit:junit in the main sources
suggested-by: vvysotskyi
* DRILL-7941 Use junit-bom to manage the dependencies
Use junit-jupiter library. It brings -api, -engine and -params as transitive dependencies, so the full power of JUnit 5.x could be easily used.
* DRILL-7941 Add junit-jupiter and junit-vintage-engine as dependencies in the root module
This way both are available for all sub-modules.
Update surefire-junit dependency
