ruff
6089e2e4 - Remove unused loops in deferred checks

Commit
93 days ago
Remove unused loops in deferred checks Summary -- While reviewing #23473, I noticed that the `while` loops in our deferred checks for `for` loops and lambdas would only be used if we pushed additional deferred scopes to the `Checker` while running lint rule code. This should actually be impossible given that the rules only receive a `&Checker` (as shown by the immutable re-borrow), and none of our tests fail when removing the loops. I guess it doesn't hurt to have the loops either since they only run once, but it did serve to confuse me today. I assume, but didn't fully confirm, that this used to be interleaved with the visiting phase, at which point additional deferred scopes could have still been added in the middle of this. Test Plan -- Existing tests
Author
Committer
Parents
Loading