ruff
7794e10f - [ty] Report workspace diagnostics while scripts initialize (#30410)

Commit
4 hours ago
[ty] Report workspace diagnostics while scripts initialize (#30410) ## Summary Today, we defer workspace diagnostics while uv sync is running. This was mainly because of a concern for how we resolved `file_settings` before https://github.com/astral-sh/ruff/pull/30407 (see that PR for details). This PR changes workspace diagnostics to return empty diagnostics for a file that has a pending uv synchronization. This is matches the pull diagnostic behavior for scripts. ty triggers a new workspace diagnostic pull when the uv synchronization finishes (successfully or not). The reason we show no diagnostic while the synchronization is running is that there's little value in showing import errors before the environment is ready. Deferring the diagnostics prevents that (and avoids an annoying flickering if the environment initializes very quickly). ## Test plan Both recordings open the same Ruff workspace with two intentional type errors and a short delay on the last uv sync. Both files are closed when their diagnostics arrive. **On main**, the Problems panel stays empty until the last script finishes syncing. Then both errors appear. https://github.com/user-attachments/assets/f5001349-a69f-49f8-9dbe-d3ff96e9e447 **With this PR**, the error in `_find_ruff.py` appears during sync. The error in `update_schemastore.py` appears when its environment is ready. https://github.com/user-attachments/assets/a6af09ac-7e22-45f3-8ca6-331807995987
Author
Parents
Loading