ruff
d4cfe1f2 - Break before slice colon

Commit
2 years ago
Break before slice colon **Summary** Break slices at the colon first, since the colon is separator with the lowest precedence and we're in a parenthesized context. **Input** ```python section_header_data = byte_array[byte_begin_index + byte_step_index * event_index : byte_begin_index + byte_step_index * (event_index + 1)] ``` **Black** ```python section_header_data = byte_array[ byte_begin_index + byte_step_index * event_index : byte_begin_index + byte_step_index * (event_index + 1) ] ``` **Current formatting** ```python section_header_data = byte_array[ byte_begin_index + byte_step_index * event_index : byte_begin_index + byte_step_index * (event_index + 1) ] ``` **Proposed formatting** ```python section_header_data = byte_array[ byte_begin_index + byte_step_index * event_index : byte_begin_index + byte_step_index * (event_index + 1) ] ``` This is another intentional black deviation, but i find it a clear style improvement. This is consistent with adding a step: ```python section_header_data2 = byte_array[ byte_begin_index + byte_step_index * event_index : byte_begin_index + byte_step_index : section_size ] ``` As-is, this regresses trailing colon comments: **in** ```python c1 = "c"[ 1: # e # f 2 ] ``` **out** ```python c1 = "c"[ 1 : # e # f 2 ] ``` Fixes #7316 **Test Plan** Added the fixtures above.
Author
Committer
Parents
Loading