uv
b239c3ec - Avoid consider PATH updated when the export is commented in the shellrc (#12043)

Comment changes are shownComment changes are hidden
Commit
135 days ago
Avoid consider PATH updated when the export is commented in the shellrc (#12043) ## Summary <!-- What's the purpose of the change? What does it do, and why? --> The way the `tool update-shell` checks if the command to export the PATH exists or not in the RC files is a blind search, and therefore if finds the command inside comments. example with .zshenv This content ``` # uv # export PATH="/Users/cholas/.local/bin:$PATH" ``` Generates the following msg ``` error: The executable directory /Users/cholas/.local/bin is not in PATH, but the Zsh configuration files are already up-to-date ``` With this change, that content won't be considered as configured and the following will be added ``` # uv export PATH="/Users/cholas/.local/bin:$PATH" ``` This will make the `update-shell` more reliable ## Test Plan I tested with and without the change with commented export in zsh in mac. Tested running `cargo run -- tool update-shell` --------- Co-authored-by: Charlie Marsh <charlie.r.marsh@gmail.com>
Author
Parents
  • crates/uv/src/commands/tool
    • File
      update_shell.rs