DeepSpeed
bee8ed56 - Address tohtana review: reject set_gradient_accumulation_boundary/offload in unmanaged mode, fix test micro-batch accounting

Commit
3 days ago
Address tohtana review: reject set_gradient_accumulation_boundary/offload in unmanaged mode, fix test micro-batch accounting - Reject set_gradient_accumulation_boundary() when managed_gradient_accumulation=False, since setting _is_gradient_accumulation_boundary breaks the step-owned boundary contract. - Reject ZeRO optimizer/param offload in unmanaged mode, closing the ZeRO-1 offload gap so behavior matches the docs (offload not yet supported). - Fix unmanaged GAS tests: build_managed_gas_config now uses micro-batch size 1 so random_dataloader's total_samples equals the micro-batch count, fixing the off-by-2x step-count assertions. - Add tests for the set_gradient_accumulation_boundary and offload rejections. Signed-off-by: Olatunji Ruwase <tunji.ruwase@snowflake.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Parents
Loading