frankenphp
bd06e11b - docs: explain why the post-force-kill reboot wait must stay unbounded

Commit
40 days ago
docs: explain why the post-force-kill reboot wait must stay unbounded Bounding this wait and giving up on the stuck thread looks like the obvious fix for #2553 (one stuck thread wedging every reboot forever), and #2573 tried exactly that. It's unsafe: php_main() calls tsrm_shutdown() on every reboot cycle, which requires every PHP thread to have already exited. Giving up on a thread whose OS thread is still alive violates that and crashes the process (confirmed by CI on #2573). Leave a comment so the same fix isn't attempted again without this context.
Author
Committer
Parents
Loading