PR #1086 implement getenv and putenv in go

implement getenv and putenv in go #1086

withinboredom merged 23 commits into main from go-env

withinboredom requested a review from

dunglas 1 year ago

dunglas requested changes on 2024-10-11

dunglas commented on 2024-10-12

dunglas requested changes on 2024-10-15

AlliBalliBaba commented on 2024-10-15

implement getenv and putenv in go

e03b78ec

fix typo

d46938d0

apply formatting

59ab1ef3

return a bool

969ceeaa

prevent ENV= from crashing

098c7956

optimization

660dc991

optimization

0c795b91

split env workflows and use go_strings

e6031cdf

clean up unused code

7b4c8ab3

update tests

4ef55f94

remove useless sprintf

41ff6b20

see if this fixes the asan issues

929a2c0a

clean up comments

71279ff6

check that VAR= works correctly and use actual php to validate the be…

2518bbb5

move all unpinning to the end of the request

61e4e20b

handle the case where php is not installed

a3cec5b2

fix copy-paste

7d64751a

optimization

67a547c7

use strings.cut

02e85457

withinboredom force pushed from 6a575f78 to bd146057 1 year ago

fix lint

d2bf2d97

override how env is filled

f97a34b6

withinboredom force pushed from fc1fc185 to f97a34b6 1 year ago

withinboredom commented on 2024-10-16

AlliBalliBaba commented on 2024-10-16

reuse fullenv

1e5abb20

use corect function

b68cf50b

withinboredom requested a review from

dunglas 1 year ago

dunglas approved these changes on 2024-10-18

withinboredom merged e812473f into main 1 year ago

withinboredom deleted the go-env branch 1 year ago

Reviewers

dunglas

AlliBalliBaba

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

frankenphp implement getenv and putenv in go #1086 Merged

implement getenv and putenv in go #1086

frankenphp
implement getenv and putenv in go
#1086

Merged