llama.cpp
fix : Dangling pointer for non-empty trigger words in lazy grammar construction
#17048
Merged

fix : Dangling pointer for non-empty trigger words in lazy grammar construction #17048

ggerganov merged 5 commits into ggml-org:master from marek-hradil:master
marek-hradil
marek-hradil marek-hradil requested a review from ggerganov ggerganov 38 days ago
marek-hradil marek-hradil changed the title fix : Dangling pointer for non-empty stop words in lazy grammar construction fix : Dangling pointer for non-empty trigger words in lazy grammar construction 38 days ago
marek-hradil fix : Dangling pointer for non-empty trigger words in llama_sampler_i…
0cc7c8ad
marek-hradil marek-hradil force pushed to 0cc7c8ad 38 days ago
ggerganov
marek-hradil Replace 'static' workaround, with keeping variable in scope for longer
f846c83f
marek-hradil
ggerganov
ggerganov dismissed these changes on 2025-11-06
Green-Sky
Green-Sky requested changes on 2025-11-06
ggerganov ggerganov dismissed their stale review 37 days ago
https://github.com/ggml-org/llama.cpp/pull/17048#discussion_r2499446715
marek-hradil Create std::array directly and pass into llama_grammar_init_impl
58056033
marek-hradil Add back the trigger pattern
8b0f05f2
ggerganov
ggerganov approved these changes on 2025-11-14
marek-hradil Missed array include
d5618588
ggerganov ggerganov merged 6cd0cf72 into master 30 days ago

Login to write a write a comment.

Login via GitHub

Assignees
No one assigned
Labels
Milestone