llama.cpp
Replace EOS with newline to prevent context/memory being flushed by EOS in interactive mode
#333
Merged
Go
Login via GitHub
Home
Pricing
FAQ
Install
Login
via GitHub
Overview
Commits
29
Changes
View On
GitHub
Replace EOS with newline to prevent context/memory being flushed by EOS in interactive mode
#333
ggerganov
merged 29 commits into
ggml-org:master
from interactive-eos-fix
Improve interactive mode's coherence after EOS
4fe9734e
Make newline token a constant
330b86ee
gjmulder
added
enhancement
gjmulder
added
generation quality
dynamically determine newline token
3eca29ec
relocate previous newline token const
94edeaf7
cleanup whitespace
ac6a9d97
print a new line on end of text in interactive
46607389
only print manual newline with reverse prompt
d9284a58
alternate approach to replace end of text tokens
2479c78b
Inject the reverse prompt again after eos in interactive mode
8009a8dd
Merge pull request #2 from slaren/interactive-eos-fix
1f4abb8d
tokenize reverse prompt when needed
3c211c64
tjohnman
requested changes on 2023-03-21
tokenize and inject only first reverse prompt
e33df8e1
tjohnman
requested changes on 2023-03-21
tokenize first reverse prompt once
52f46ef7
tjohnman
requested changes on 2023-03-21
Merge branch 'master' into interactive-eos-fix
6bcbe507
tjohnman
approved these changes on 2023-03-21
slaren
approved these changes on 2023-03-21
Merge branch 'master' into interactive-eos-fix
6fb0db31
add newline token
1752bc92
add newline token
23bb78fb
tokenize/inject reverse prompt for refactor
da0837f5
tokenize nothing for antiprompt if no reverse
c4efdb22
Update main.cpp
879da33a
Update main.cpp
e590787a
tokenize and inject reverse prompt as needed
4e4cfdfb
rabidcopy
requested a review
from
tjohnman
2 years ago
not needed
6a4cfc4d
slaren
commented on 2023-03-22
remove newline token
10206d03
remove newline token
8f83ce83
tokenize newline token
7864eef9
Merge branch 'master' into interactive-eos-fix
666c5a03
rabidcopy
changed the title
Improve interactive mode's coherence after EOS
Replace EOS with newline to prevent context/memory being flushed by EOS in interactive mode
2 years ago
add space to comment
88df270f
tjohnman
approved these changes on 2023-03-22
ggerganov
requested changes on 2023-03-23
Update main.cpp
55b899b8
ggerganov
approved these changes on 2023-03-23
ggerganov
merged
2e17dfd8
into master
2 years ago
rabidcopy
deleted the interactive-eos-fix branch
2 years ago
Login to write a write a comment.
Login via GitHub
Reviewers
ggerganov
slaren
tjohnman
Assignees
No one assigned
Labels
enhancement
generation quality
Milestone
No milestone
Login to write a write a comment.
Login via GitHub