llama.cpp
hparam comparison uses memcpy for floating point comparison, which is in general a bad idea
#3446
Merged
Merged
hparam comparison uses memcpy for floating point comparison, which is in general a bad idea #3446
ggerganov
merged
5 commits into
ggml-org:master
from
l3utterfly:hparam-compare
fixed floating point comparison issues
66f2063d
ggerganov
approved these changes
on 2023-10-03
updated implementation for hparam comparison to handle inf and NaN
16f45c4d
fixed code review comments
d9cb48f0
minor simplification
bde943e6
cebtenzzre
approved these changes
on 2023-10-04
rename is_float_eq -> is_float_close
4cffcb84
Login to write a write a comment.
Login via GitHub