llama.cpp
py: add_array() will not add to kv store if value is an empty array
#8774

Merged

py: add_array() will not add to kv store if value is an empty array #8774

mofosyne merged 2 commits into ggml-org:master from mofosyne:8769-bug-valueerror-invalid-gguf-metadata-value-type-or-value-due-to-missing-tags-in-the-model-card

github-actions added python

mofosyne requested a review from

KerfuffleV2 1 year ago

mofosyne requested a review from

compilade 1 year ago

mofosyne added bugfix

mofosyne added Review Complexity : Low

gguf_writer.py: add_array() should not add to kv store if empty

02665ba3

compilade approved these changes on 2024-07-30

mofosyne force pushed to 02665ba3 1 year ago

Apply suggestions from code review

e96d2634

mofosyne added merge ready

mofosyne merged 7e72aa74 into master 1 year ago

mofosyne deleted the 8769-bug-valueerror-invalid-gguf-metadata-value-type-or-value-due-to-missing-tags-in-the-model-card branch 1 year ago

Reviewers

compilade

KerfuffleV2

Assignees

No one assigned

Labels

bugfix Review Complexity : Low python merge ready

Milestone

No milestone

llama.cpp py: add_array() will not add to kv store if value is an empty array #8774 Merged

py: add_array() will not add to kv store if value is an empty array #8774

llama.cpp
py: add_array() will not add to kv store if value is an empty array
#8774

Merged