P cores
#934

Merged

fix(perf/UX): Use num physical cores by default, warn about E/P cores #934

ggerganov merged 19 commits into ggml-org:master from jon-chuang:jon/use-hardware-cores

commit

1caa4dcf

fix

f181c28e

jon-chuang commented on 2023-04-13

try-catch

8694318c

jon-chuang changed the title ~~fix(params): Use hardware cores by default~~ fix(params): Use num hardware cores by default 3 years ago

jon-chuang changed the title ~~fix(params): Use num hardware cores by default~~ fix(params): Use num physical cores by default 3 years ago

prusnak requested changes on 2023-04-13

prusnak commented on 2023-04-13

apply code review

e0325353

Merge branch 'master' of https://github.com/ggerganov/llama.cpp into …

b17d54ed

improve

02b0fe86

prusnak requested changes on 2023-04-13

improve

3fa88370

add macos headers

e524ce99

done

81edec97

jon-chuang changed the title ~~fix(params): Use num physical cores by default~~ fix(UX): Use num physical cores by default, clip default to 4, and warn about clipped default 3 years ago

jon-chuang changed the title ~~fix(UX): Use num physical cores by default, clip default to 4, and warn about clipped default~~ fix(perf/UX): Use num physical cores by default, clip default to 4, and warn about clipped default 3 years ago

remove color

1a6c8cf7

ivanstepanovftw commented on 2023-04-15

sw commented on 2023-04-16

fix windows

9ee4719e

minor

df2d350c

Merge branch 'master' of https://github.com/ggerganov/llama.cpp into …

42c297b9

fix

4a98a0f2

jon-chuang changed the title ~~fix(perf/UX): Use num physical cores by default, clip default to 4, and warn about clipped default~~ fix(perf/UX): Use num physical cores by default, warn about E/P cores 3 years ago

DannyDaemonic requested changes on 2023-04-27

Apply suggestions from code review

710c4bbd

remove

f1c19d88

Merge branch 'master' of https://github.com/ggerganov/llama.cpp into …

496d291d

minor

2fbc90f2

minor

78761b10

ggerganov approved these changes on 2023-04-30

ggerganov merged a5d30b1f into master 3 years ago

Reviewers

ggerganov

DannyDaemonic

prusnak

ivanstepanovftw

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

llama.cpp fix(perf/UX): Use num physical cores by default, warn about E/P cores #934 Merged

fix(perf/UX): Use num physical cores by default, warn about E/P cores #934

llama.cpp
fix(perf/UX): Use num physical cores by default, warn about E/P cores
#934

Merged