[.ai] add self-review skill (#13917)
* [.ai] add self-review skill, retire parity-testing skill, and tighten the agent guides
- New `self-review` skill mirroring the `@claude` CI review (rubric from
review-rules.md, call-path dead-code analysis), report-only, with the report
flagging what to fix before submitting (blocking + dead code) vs what to leave
for the actual review.
- Remove the WIP `parity-testing` skill; preserve its pitfalls as
`model-integration/pitfalls.md` (numerical-discrepancy reference).
- model-integration: restructure around a grouped checklist, default-to-modular,
an overall file-structure sketch (details deferred to the guides), a
fresh-conversion `Model parity test` example (internal, not shipped), and a
filled-in weight/checkpoint-conversion section.
- Centralize the loading rule (from_pretrained / from_single_file, no custom
loaders) in models.md; add per-folder File structure sections to models.md /
pipelines.md; default-to-modular note in pipelines.md.
- AGENTS.md: dedicated 'Self-review before a PR' and 'Reference guides' sections.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* [.ai] simplify pitfalls #6 and drop the model-storage / injection-test entries
Trim pitfall #6 to the essential point (small dtype diffs compound into a large
final difference), remove the `/tmp` model-storage and incomplete-injection-test
pitfalls, and renumber 1-16 with cross-references updated.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* [.ai] drop parity-harness-specific pitfalls
With the parity-testing skill gone, remove the stale-test-fixtures pitfall (saved
tensors / cross-pipeline fixtures no longer apply) and de-jargon the noise-dtype
detection note. Keeps the pitfalls list generic to numerical discrepancy.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* [.ai] trim pitfalls to a concise possible-causes reference
Drop the variable-shadowing and decoder-config pitfalls and the noise-dtype
'Detection' aside, tighten the remaining entries, renumber 1-12 (cross-refs
updated), and reframe the intro as a non-checklist reference list of possible
causes to consult only when outputs don't match.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* Apply suggestion from @yiyixuxu
* Apply suggestion from @yiyixuxu
* [docs] update contributing guide for the self-review skill
Replace the retired parity-testing skill with self-review in the skills list, and
add a 'Self-review before opening' step to the AI-assisted contributions section:
run the self-review skill / review-rules, fix blocking issues + dead code, and
treat the @claude CI review as a non-authoritative helper (note any intentional
skips in the PR for the reviewer).
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* Apply suggestions from code review
Co-authored-by: Sayak Paul <spsayakpaul@gmail.com>
* [.ai] fix dangling pitfalls ref and broaden self-review scope
- Drop the broken 'pitfalls.md #10' reference in the conversion step (the /tmp
model-storage pitfall was removed); save to a local path instead.
- Self-review now reviews the whole diff, not just src/diffusers/ and .ai/ — a
contributor should review their own tests/docs/scripts too (the CI's scoping is
a safety measure for untrusted PRs). Reword to 'same rubric as the CI'.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Co-authored-by: Sayak Paul <spsayakpaul@gmail.com>
