update agent doc to cover more on tests + include it in review CI scope (#14197)
* Add agent-doc gotcha: build pipeline test components from real classes, not mocks
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* Document modular pipeline tests; soften tiny-repo policy; move mock rule to skill only
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* Split testing conventions into .ai/testing.md; include tests/ in review scope
Move the Testing section out of the model-integration skill into a
standalone .ai/testing.md so it loads in both the authoring and review
flows, add it to review-rules' reading list and the reference guides,
extend the mock rule to call-level doubles (monkeypatched component
methods), and widen the @claude CI reviewer's review scope to tests/
(edit/commit scope unchanged).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* Document how to run modular pipelines/blocks; add callback_kwargs gotcha
- modular.md: new 'Running a modular pipeline' section — init_pipeline()/
load_components()/output= usage, from_blocks_dict composition,
update_components() for config values, and the anti-pattern of calling
blocks directly with a hand-built PipelineState
- testing.md: modular block tests run through the pipeline API and assert
on outputs; tiny repos must mirror the real checkpoint's shape (per-variant
repos when configs differ); bespoke tests live on the tester class
- pipelines.md: callback_kwargs must be built with a loop — locals() inside
a dict comprehension sees the comprehension's scope and always KeyErrors
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* Apply suggestions from code review
Co-authored-by: Sayak Paul <spsayakpaul@gmail.com>
---------
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: Sayak Paul <spsayakpaul@gmail.com>