huggingface_hub
ab2ddb4a - fix: use module logger consistently and narrow bare except clauses (#3924)

Commit
249 days ago
fix: use module logger consistently and narrow bare except clauses (#3924) * fix: correct inverted `skip_if_logged_in` logic in login functions The condition `if not skip_if_logged_in and get_token() is not None` caused `interpreter_login()` and `notebook_login()` to skip the prompt when `skip_if_logged_in=False` (the default), which is the opposite of the intended behavior. Removed the `not` so the early return only triggers when `skip_if_logged_in=True` and a token already exists, matching the docstring: "If True, do not prompt for token if user is already logged in." Fixes #3917 * fix: use module logger consistently and narrow bare except clauses - _upload_large_folder.py: replace `logging.info()` with `logger.info()` for consistency with the rest of the file (30+ other logger.* calls) - hf_file_system.py: replace bare `except:` with `except OSError:` in `exists()` and `isfile()` to match the adjacent `isdir()` method * Apply suggestions from code review Co-authored-by: Lucain <lucainp@gmail.com> --------- Co-authored-by: easonysliu <easonysliu@tencent.com> Co-authored-by: Lucain <lucain@huggingface.co> Co-authored-by: Lucain <lucainp@gmail.com>
Author
Parents
Loading