[SYCL] Cleanup the deprecated Intel attribute logic (#3036)
We previously sprinkled deprecated attribute logic around to a few places
when we could instead use a single helper function to do the work for us.
This also adds a fix-it hint when we find a deprecated attribute to help
the user convert to the new spelling.
