langchain
e2bc8365 - Fix #4087 by setting the correct csv dialect (#4103)

Commit
2 years ago
Fix #4087 by setting the correct csv dialect (#4103) The error in #4087 was happening because of the use of csv.Dialect.* which is just an empty base class. we need to make a choice on what is our base dialect. I usually use excel so I put it as excel, if maintainers have other preferences do let me know. Open Questions: 1. What should be the default dialect? 2. Should we rework all tests to mock the open function rather than the csv.DictReader? 3. Should we make a separate input for `dialect` like we have for `encoding`? --------- Co-authored-by: = <=>
Author
Parents
Loading