mathlib3
62a56268 - chore(algebra/order/hom/basic): move positivity extension (#17758)

Commit
3 years ago
chore(algebra/order/hom/basic): move positivity extension (#17758) The positivity extension for functions instantiating `nonneg_hom_class` (e.g. the absolute value) currently lives in the file `algebra/order/hom/basic` where `nonneg_hom_class` is introduced. This imports all of positivity (and therefore all of the theory of ordered fields and powers, much of norm_num, etc) into `algebra/order/hom/basic`, which is a lot more theory than needed. Also, since the (apparent) only import of that file is `tactic/positivity`, it confuses the import-graph generator when the `--exclude-tactics` flag is turned on, leading to issues such as this one mentioned on the port wiki currently: ``` algebra.order.absolute_value: 'No: incorrectly marked as ready: needs algebra.hom.group' ``` Let's instead put that positivity extension in the core `tactic/positivity` file. This requires importing `algebra/order/hom/basic` to `tactic/positivity` but it's not a heavy import since it's short and its only import `algebra/hom/group` was already imported. Most of this PR consists of adding explicit imports to files downstream from `algebra/order/hom/basic`, when these imports were previously available as part of the big mass of positivity prerequisites. This PR touches a frozen file (`algebra/order/hom/basic`) but only for meta code, which I believe is permissible.
Author
Parents
Loading