llvm-project
0364bafd - [clang] Fix possible nullptr deref in BuildCXXNestedNameSpecifier (#166995)

Commit
8 hours ago
[clang] Fix possible nullptr deref in BuildCXXNestedNameSpecifier (#166995) There is a possible nullptr deref in BuildCXXNestedNameSpecifier when calling ExtendNestedNameSpecifier or using isa<>. This initially showed up as a crash in clangd, that didn't manifest in when compiling w/ clang. The reduced test case added in this patch, however does expose the issue in clang. Testing locally shows that both this test case and the original clangd issue are fixed by checking the validity of the pointer before trying to dispatch. Since all code paths require the pointer to be valid (usually by virtue of a dyn_cast or isa<> check), there should be no functional difference. Fixes #166843
Author
Parents
Loading