llvm-project
13ae9ea4 - [MLIR] Avoid resolving callable outside the analysis scope in DeadCodeAnalysis (#155088)

Commit
22 days ago
[MLIR] Avoid resolving callable outside the analysis scope in DeadCodeAnalysis (#155088) We are using the symbol table machinery to lookup for a callable, but when the analysis scope if a function, such lookup will resolve outside of the scope. This can lead to race-condition issues since other passes may operate in parallel on the sibling functions. The callable would be discarded right after the lookup (we check the analysis scope), so avoiding the lookup is NFC. For the DataFlow solver, we're looking at the top-level operation, and if it isn't a SymbolTable we disable the interprocedural optimization in the solver config directly. This strategy isn't NFC but seems reasonnable and does not encounter any change in behavior in practice in tree. Fix #154948
Author
Parents
Loading