llvm-project
14cdf0c5 - [mlir] Fix mlir-pdll-lsp-server link. (#220123)

Commit
8 days ago
[mlir] Fix mlir-pdll-lsp-server link. (#220123) This is the same fix TableGenLspServerLib got in 9e469ced42cd. This addresses the mlir-pdll-lsp-server instance of #152371. MLIRPdllLspServerLib transitively needs LLVMTableGen, which is not part of libLLVM.so, so MLIRPDLLParser already brings in static LLVMSupport. Linking the dylib here as well gives mlir-pdll-lsp-server two copies of LLVMSupport. Linking still succeeds, but with assertions view-output.test fails. The test trips over the two copies having different Hashing.h seeds, which is a separate defect to be addressed in another PR. It has not shown up in CI because it needs the dylib and assertions at the same time, which rarely coincide. It also only became reachable once a3a25996b114 moved the LSP transport into libLLVM.so. Assisted-By: Claude Opus 5
Author
Parents
Loading