[IR] Consolidate ValueMap iterator classes (NFC) (#161777)
This patch consolidates ValueMapIterator and ValueMapConstIterator
into ValueMapIteratorImpl. ValueMapIteratorImpl takes a boolean
template parameter to determine whether it should act as a const
iterator or a non-const one. ValueMapIterator and
ValueMapConstIterator are now type aliases of ValueMapIteratorImpl.
