llvm-project
29796549 - [CIR][HIP] Add Stub body emission test coverage and Fix kernelHandle storage (#179823)

Commit
53 days ago
[CIR][HIP] Add Stub body emission test coverage and Fix kernelHandle storage (#179823) Related: https://github.com/llvm/llvm-project/issues/179278, https://github.com/llvm/llvm-project/issues/175871 Besides adding extra test coverage for hip: Given that HIP represents kernel handles as a global Op. In my previous patch there was a slight miss-use of the CIR api. since `getOrCreateCIRGlobal` expects a VarDecl for location info but `gd.getDecl()` (in this scope) is a FunctionDecl, trying to cast it to the proper type would provoke that value to be null. Causing a crash when generating the proper mlir location from the AST. here: https://github.com/llvm/llvm-project/blob/fab5b1858d02ffed88b76d33f7c691ee4e0c82fb/clang/lib/CIR/CodeGen/CIRGenModule.cpp#L731 Fixed it by using `createGlobalOp` which allows to use the location from the proper funcOp itself.
Author
Parents
Loading