llvm-project
2f7e685e - [MLIR] Ensure deterministic parallel verification (#134963)

Commit
175 days ago
[MLIR] Ensure deterministic parallel verification (#134963) `failableParallelForEach` will non-deterministically early terminate upon failure, leading to inconsistent and potentially missing diagnostics. This PR uses `parallelForEach` to ensure all operations are verified and all diagnostics are handled, while tracking the failure state separately. Other potential fixes include: - Making `failableParallelForEach` have deterministic early-exit behavior (or have an option for it) - I didn't want to change more than what was required (and potentially incur perf hits for unrelated code), but if this is a better fix I'm happy to submit a patch. - I think all diagnostics that can be detected from verification failures should be reported, so I don't even think this would be correct behavior anyway - Adding an option for `failableParallelForEach` to still execute on every element on the range while still returning `LogicalResult`
Author
Parents
Loading