llvm-project
383b3268 - [llvm-debuginfo-analyzer] Fix ODR violation in llvm::logicalview::LVObject (#140265)

Commit
108 days ago
[llvm-debuginfo-analyzer] Fix ODR violation in llvm::logicalview::LVObject (#140265) Some data members are only part of a class definition in a Debug build, e.g. `LVObject::ID`. If `debuginfologicalview` is used as a library, `NDEBUG` cannot be used for this purpose, as this PP macro may have a different definition in a downstream project, which in turn triggers an ODR violation. Fix it by - Making `LVObject::ID` an unconditional data member. - Making `LVObject::dump()` non-virtual. Rationale: `virtual` is not needed (and it calls `print()`, which is virtual anyway). Fixes #139098.
Author
Parents
Loading