Reapply "[ORC] Simplify WaitingOnGraph::Coalescer::remove." (#183231)
This reapplies 85354c6d8bc, which was reverted in d7347c0b81a due to bot
failures.
In this commit further changes are made to address the bot failure, and
general readability.
WaitingOnGraph::Coalescer::remove is renamed WaitingOnGraph::Coalescer::erase,
since its behavior is now similar to common container erase operations.
WaitingOnGraph::Coalescer::clear is provided to enable a fast reset of
Coalescer state.
SuperNodeBuilder::takeSuperNodes is updated to clear the Coalescer state before
returning the SuperNodes, ensuring that future calls to SuperNodeBuilder::add
do not trip the assert that caused the builder failures.