[CodeGen] Assume BBIDs are set in BasicBlockSections and matching/inference (#235056)
MachineFunction::CreateMachineBasicBlock always assigns a BBID when
-basic-block-sections=list (or the BB address map) is enabled. Both the
hot-cluster construction in BasicBlockSections and
BasicBlockMatchingAndInference::initWeightInfoByBBID only run in list
mode, so the checks for a missing BBID, and the fallback to the block
number, are dead code. Remove them.