llvm-project
5ad9cec5 - [RISCV] NFC: Use the new "let append" TableGen feature to reduce duplication (#198761)

Commit
10 days ago
[RISCV] NFC: Use the new "let append" TableGen feature to reduce duplication (#198761) llvm#182382 introduced a language extension to accumulate field values: “append” concatenates the new value after the current value, whilst "prepend" concatenates before the existing value. This change uses that feature to eliminate repetition in the definition of some of the compressed instructions. For example, line 267 of RISCVIntrInfoC.td establishes a scope for “`let Predicates = [HasStdExtZca] in {`”; this scope ends on line 515. Meanwhile, line 454 wants to add the `IsRV64` predicate for a single instruction but was forced to duplicate the previous condition as well: “`let Predicates = [HasStdExtZca, IsRV64] in`”. That’s no longer necessary since the addition can now be explicit: “`let append Predicates = [IsRV64] in `” I‘ve verified that this change has no effect on the TableGen output. It seems quite likely that this same change could be made in some of the other RISC-V TableGen source files…
Author
Parents
Loading