[mlir][nfc] De-duplicate tests from `Type::isIntOrFloat` (#129710)
This PR makes sure that we always use `Type::isIntOrFloat` rather than
re-implementing this condition inline. Also, it removes `isScalarType`
that effectively re-implemented this method.