llvm-project
6563d250 - [sanitizer_common] fix shadowed ret hiding symbolizer read failures. (#209971)

Commit
7 days ago
[sanitizer_common] fix shadowed ret hiding symbolizer read failures. (#209971) The inner `bool ret` from ReadFromFile shadowed the outer one that is returned, so a dead/closed symbolizer (0-byte read or read error) was reported as success: SendCommand never restarted the crashed process, and the addr2line path aborted on a CHECK over an empty buffer. Regression from acfeb1a6c244. Add a regression test that feeds an EOF fd through ReadFromSymbolizer and expects failure.
Author
Parents
Loading