llvm-project
89157ec2 - [BOLT] Keep ambiguous references next to function boundaries valid

Commit
43 days ago
[BOLT] Keep ambiguous references next to function boundaries valid A reference into code without a relocation that names its target, e.g. a RIP-relative LEA whose relocation was against a section symbol, cannot be told apart from "Next - Delta" and "Prev + Offset" when it lands right before or after a function start. HHVM built with LLVM 23 has such a reference to "sqlite3RCStrUnref - 1", which lands in padding and makes BOLT fail with -strict. Without padding, BOLT silently kept such references relative to the preceding function. See bolt/test/X86/unanchored-code-reference.s. BOLT now collects these references from code and, when they are within --boundary-ref-distance bytes (default 2) of a function start, keeps the functions around them in place in lite mode. When all functions are processed, it emits those functions unoptimized and back-to-back with the original bytes between them, and checks after linking that they kept their size and distance. Absolute references right before a function start are now relative to that function. This replaces the workaround for "fptr - 1" in de-virtualized member function pointer calls, which dropped the relocation and left the input address in the code.
Author
Committer
Parents
Loading