llvm-project
8f58cfec - [CIR][NFC] Update out-of-sync OGCG checks in test CIRGen/builtin_bit (#177189)

Commit
44 days ago
[CIR][NFC] Update out-of-sync OGCG checks in test CIRGen/builtin_bit (#177189) This patch updates various out-of-sync OGCG checks in the test file `clang/test/CIR/CIRGen/builtin_bit.cpp`. These checks are all related to the original clang CodeGen for the bitwise rotate builtins. The OGCG patch #160259 inserts a new `urem` instruction before calling the `llvm.fshr.*` intrinsic, which truncates the rotate amount against the input's bit width. This breaks our OGCG checks. I have not yet dug deep enough into the rationale behind the OGCG patch. The LLVM intrinsic `llvm.fshr.*` should already handle the truncation, and the new `urem` instruction seems redundant in terms of semantic correctness. Thus I choose not to hurry to also update relevant CIRGen code to match OGCG behavior in this patch.
Author
Parents
Loading