llvm-project
96839a47 - [llvm-gsymutil] Ensure stable ordering of merged functions (#120796)

Commit
187 days ago
[llvm-gsymutil] Ensure stable ordering of merged functions (#120796) Previously, the test `llvm/test/tools/llvm-gsymutil/ARM_AArch64/macho-gsym-merged-callsites-dsym.yaml` [was disabled](https://github.com/llvm/llvm-project/pull/119957/files) due to failing on Linux. The issue is that the merged functions appear in a different order in the final produced `gSYM`. To ensure deterministic ordering of merged functions, we change the sorting of functions to use the `stable_sort` algorithm. Before merged functions, this was not an issue as the address is used as a comparator in the sorting algorithm so there was no chance of two functions testing as identical according to the comparator. Confirmed that test now passes locally with `-DLLVM_ENABLE_EXPENSIVE_CHECKS=ON`.
Author
Parents
  • llvm
    • lib/DebugInfo/GSYM
      • File
        GsymCreator.cpp
    • test/tools/llvm-gsymutil/ARM_AArch64
      • File
        macho-gsym-merged-callsites-dsym.yaml