llvm-project
a318c501 - [mlir][tosa] Remove NegateOp to SubOp and 48-bit promotion in TosaToLinalg (#170622)

Commit
67 days ago
[mlir][tosa] Remove NegateOp to SubOp and 48-bit promotion in TosaToLinalg (#170622) The patch motivated by Tosa Conformance test negate_32x45x49_i16_full failure. TosaToLinalg pass has an optimization to transfer Tosa Negate to Sub if the zero points are zeros. However, when the input value is minimum negative number, the transformation will cause the underflow. By removing the transformation, if zp = 0 it would do the promotion to avoid the underflow. Promotion types could be from int32 to int48. TOSA negate specification does not mention support for int48. Should we consider removing the promotion to int48 to stay aligned with the TOSA spec?
Author
Parents
Loading