llvm-project
a5bac50f - [llvm-gsymutil] Suppress all error and warning messages when `--quiet` (#215912)

Commit
94 days ago
[llvm-gsymutil] Suppress all error and warning messages when `--quiet` (#215912) # Motivation When converting a large iOS dSYM, it can sometimes emit too many errors and warnings. For example, one large dSYM produced 437,389 "error:" and 24,224 "warning:" lines. When these logs are unwanted, they make the output unreadable and consumes unnecessary disk/network resources. The current `--quiet` option only silences _some (not all)_ warnings, and _none_ of the errors. The intention for this option was to silence all of them. This patch fixes the above, so that the `--quiet` option silences all error and warning messages. # Implementation Moved the `bool Quiet = false` ctor parameter from `GsymCreator` to `OutputAggregator`, which is the single funnel every diagnostic already flows through, so that the callsites of `OutputAggregator::Report()` will all be covered without having to specify `Quiet`. A few places in `GsymCreator` which were not guarded by `IsQuiet()` previously are fixed automatically by the above.
Author
Parents
Loading