llvm-project

a8918b6b - Fix -Wunused-template in assorted LLVM library helpers (NFC) (#202988)

Fix -Wunused-template in assorted LLVM library helpers (NFC) (#202988) Function templates across a few low-level LLVM libraries trip `-Wunused-template`. Two kinds of fix here: - Header templates with internal linkage. `CheckedArithmetic.h`: move `checkedOp` out of the anonymous namespace into `llvm::detail` and update its callers. `BitcodeConvenience.h`: drop `static` on `emitOps`. `MCDCTypes.h`: drop `static` on `getParams`. Templates are implicitly inline, so this is a linkage-only change. - Dead code with no callers, removed: `makeNode` in `ItaniumManglingCanonicalizer.cpp` (a base-class helper shadowed by the derived class), `addDirectiveHandler` in `GOFFAsmParser.cpp`, and `getWithDefault` in `ResourceFileWriter.cpp`. NFC. Part of #202945.