Reapply "[lldb] Remove ConstString from FileSpec" (#211927) (#214599)
This reverts commit 3af6879ba3d68d485e5e4e753223e4ed7a283df5.
I've re-run the tests on with ASAN and UBSAN to detect any potential
issues. On my M5 machine it does not introduce any new regressions in
the test suite.