llvm-project

af27159e - [clang-tidy] Show correct diff instructions when check_alphabetical_order.py fails (#170971)

[clang-tidy] Show correct diff instructions when check_alphabetical_order.py fails (#170971) Before the change, when given such incorrect ordering: ``` :doc:`modernize-use-designated-initializers <modernize/use-designated-initializers>`, "Yes" :doc:`modernize-use-equals-default <modernize/use-equals-default>`, "Yes" :doc:`modernize-use-emplace <modernize/use-emplace>`, "Yes" :doc:`modernize-use-equals-delete <modernize/use-equals-delete>`, "Yes" :doc:`modernize-use-integer-sign-comparison <modernize/use-integer-sign-comparison>`, "Yes" ``` Script output suggested removing `modernize-use-equals-default` line that came after `modernize-use-emplace` but in my actual file, we can see that current ordering is different (same as 2nd part of the diff): ``` # | :doc:`modernize-use-constraints <modernize/use-constraints>`, "Yes" # | :doc:`modernize-use-default-member-init <modernize/use-default-member-init>`, "Yes" # | :doc:`modernize-use-designated-initializers <modernize/use-designated-initializers>`, "Yes" # | :doc:`modernize-use-emplace <modernize/use-emplace>`, "Yes" # | - :doc:`modernize-use-equals-default <modernize/use-equals-default>`, "Yes" # | :doc:`modernize-use-equals-delete <modernize/use-equals-delete>`, "Yes" # | :doc:`modernize-use-integer-sign-comparison <modernize/use-integer-sign-comparison>`, "Yes" # | :doc:`modernize-use-nodiscard <modernize/use-nodiscard>`, "Yes" # | --- 316,323 ---- # | :doc:`modernize-use-constraints <modernize/use-constraints>`, "Yes" # | :doc:`modernize-use-default-member-init <modernize/use-default-member-init>`, "Yes" # | :doc:`modernize-use-designated-initializers <modernize/use-designated-initializers>`, "Yes" # | + :doc:`modernize-use-equals-default <modernize/use-equals-default>`, "Yes" # | :doc:`modernize-use-emplace <modernize/use-emplace>`, "Yes" # | :doc:`modernize-use-equals-delete <modernize/use-equals-delete>`, "Yes" ``` We need to invert the diff, so the user can correctly follow its recommendations.