llvm-project
c47042c5 - [mlir][SPRIV][NFC] Avoid rollback in `TypeCastingOpPattern` (#136284)

Commit
232 days ago
[mlir][SPRIV][NFC] Avoid rollback in `TypeCastingOpPattern` (#136284) This pattern used to create an op and then attached the converted rounding mode attribute. When the latter failed, the pattern aborted and a rollback was triggered. This commit inverses the logic: the converted rounding mode is computed first, so that no changes have to be rolled back. Note: This is in preparation of the One-Shot Dialect Conversion refactoring.
Parents
Loading