llvm-project
cfdacce2 - [NFC] Re-enable MSVC C4611 diagnostic (#182100)

Commit
5 days ago
[NFC] Re-enable MSVC C4611 diagnostic (#182100) From MSDN: https://learn.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-4-c4611?view=msvc-170 I do not believe this diagnostic happens in our code base any longer. This diagnostic was disabled in 5c73e1f85c5d37a5b037c70f3c112eec5646acb3 and the review for it (https://reviews.llvm.org/D8572) says there were two instances of the diagnostic as of 2015. But because this is about interaction between `setjmp` and C++ object destruction, I don't think we need to disable this diagnostic across the entire monorepo; we can silence it for the project using setjmp if it still exists. I enabled the diagnostic locally and my build was warning-free but I'd like to see how pre- (and post-)commit CI do with this one.
Author
Parents
Loading