llvm-project

dc83ad2b - [CIR] Fix incorrect CIR_GlobalOp.global_visibility assembly format (#189673)

[CIR] Fix incorrect CIR_GlobalOp.global_visibility assembly format (#189673) Closes #189666 . Fix incorrect printing and parsing of `cir.global` if `global_visibility` attribute is present. Incorrect assembly format ``` (`` $global_visibility^)? ``` Resulted in keyword sticking to previous word and producing incorrect cir like this: ``` cir.globalhidden external dso_local @hidden_var = #cir.int<10> : !s32i {alignment = 4 : i64} loc(#loc22) cir.global "private"hidden internal dso_local @hidden_static_var = #cir.int<10> : !s32i {alignment = 4 : i64} loc(#loc24) ``` Using custom parser/printer that is used in `cir.func` parser fixes this issue and makes printed/parsed attribute for functions and global values consistent. Also added tests for both global values and functions.