matrix-js-sdk
4ba1341f - Fix highlights from threads disappearing on new messages (#4106)

Commit
1 year ago
Fix highlights from threads disappearing on new messages (#4106) * Fix highlights from threads disappearing on new messages This changes interface of Room, so this is a BREAKING CHANGE. Correctly mirrors the logic we use for room notifications for thread notifications, ie. set only the total notifications count from the server if it's zero. I'm not delighted with this since it ends up with function on room whose contract is to do something frankly, deeply weird and unintuitive. However, this is the hack we use for room notifications and it, empirically, works well enough. To do better, we'd need much more complex logic to overlay notification counts for decrypted messages. Fixes https://github.com/element-hq/element-web/issues/25523 * Add tests for the special notification behaviour in syncing * Correctly copy the room logic for reseting notifications We were always ignoring the highlight count, even for encrypted rooms, which was broken because we don't do the local calculation for unencrypted rooms.
Author
Parents
Loading