onnxruntime
08699c80 - Address SDL warnings in recent STFT changes (#14847)

Commit
3 years ago
Address SDL warnings in recent STFT changes (#14847) ### Description Addresses two separate SDL warnings, neither of which point to a cause for concern: 1. `The expression '0<=_Param_(1)&&_Param_(1)<=3-1' is not true at this call. at D:\a\_work\1\s\onnxruntime\core\providers\dml\DmlExecutionProvider\src\Operators\\DmlSTFT.h@443,33`. In other words, the tool thinks one of the calls to `barriers[barrierCount++]` will be an index-of-of-range issue, even those this is not currently possible. Switching a normal C array avoids this complaint. 2. `'_Param_(1)' could be '0': this does not adhere to the specification for the function 'CD3DX12_RESOURCE_BARRIER::UAV'`. The d3dx12 helper for UAV barriers has the wrong SAL annotation and doesn't allow a null resource (`_In_`), even though a null resource is legal and well defined. Updated the annotation to `_In_out_` and created a PR upstream. ### Motivation and Context Pacify SDL tasks in CI pipelines.
Author
Parents
Loading