Commit
2 years ago
gh-35825: Fix tests for singular 4.3.2p2 <!-- Please provide a concise, informative and self-explanatory title. --> <!-- Don't put issue numbers in the title. Put it in the Description below. --> <!-- For example, instead of "Fixes #12345", use "Add a new method to multiply two integers" --> See: https://github.com/sagemath/sage/issues/35676#issuecomment-1585711529 Both failures due to testing non-canonical output which gives different results on singular 4.3.2p2 vs 4.3.2p1. As mentioned in https://github.com/sagemath/sage/issues/35676#issuecomment-1597921576, printing `decomp` could be eliminated in both tests, since later on the result is checked for correctness. However, they are documentation examples and it might be useful for a user to see how the output looks like. ### :books: Description <!-- Describe your changes here in detail. --> <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes #12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### :memo: Checklist <!-- Put an `x` in all the boxes that apply. It should be `[x]` not `[x ]`. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: https://github.com/sagemath/sage/pull/35825 Reported by: Gonzalo TornarĂ­a Reviewer(s):
Author
Release Manager
Loading