Commit
2 years ago
gh-36224: Add cycle_type() and fix to_cycle() to SignedPermutation. <!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes #1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> We fix a "bug" in `to_cycle()` of `SignedPermutation` that does not return the negation of a positive cycle, and add an option to hide these cycles (the current behavior in Sage). We add a `cycle_type()` method that returns the corresponding `PartitionTuple` object. We add a `conjugacy_class_reprensentative()` method. A while-we-are-at-it thing: we fix a bug in the error output for `Permutation.element_in_conjugacy_class()` (which a better name IMO is `conjugacy_class_reprensentative()`). <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes #12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### :memo: Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation accordingly. ### :hourglass: Dependencies <!-- List all open PRs that this PR logically depends on - #12345: short description why this is a dependency - #34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: https://github.com/sagemath/sage/pull/36224 Reported by: Travis Scrimshaw Reviewer(s): ayyer, Martin Rubey, Travis Scrimshaw
Author
Release Manager
Loading